Skip to content

CI: Add PDAF builds#82

Open
jjokella wants to merge 24 commits into
masterfrom
dev-pdaf-CI
Open

CI: Add PDAF builds#82
jjokella wants to merge 24 commits into
masterfrom
dev-pdaf-CI

Conversation

@jjokella
Copy link
Copy Markdown
Contributor

@jjokella jjokella commented Jul 11, 2025 •
edited
Loading

Started from issue #81

Opening PR for testing CI.

Related PDAF-PR:

jjokella added 8 commits July 11, 2025 11:16
@jjokella
udpate models/parflow_pdaf to tsmp-pdaf-patched
6b2ea40 
includes: commenting out unused variables in PDAF code
@jjokella
BuildParFlow: Turn "eCLM" on for CLM3.5
b005f8d 
in order to get Oasis-files compiled correctly
@jjokella
BuildParFlow: Compiler option -Wno-unused-variable for PDAF-builds
b3fd901 
Error
```
parflow_pdaf/pfsimulator/parflow_lib/solver_richards.c:1817:16: error:
unused variable ‘pfl_start’ [-Werror=unused-variable]
```

Background: In `PseudoAdvanceRichards`, there are many unused
variables.
@jjokella
udpate models/parflow_pdaf to tsmp-pdaf-patched-hypre-cuda-fixes
dfc7e73 
branch matching current generic ParFlow from TSMP2
@jjokella
update model/pdaf to tsmp-pdaf-patched-outdir-fix-clm35
a60194c
@jjokella
update model/pdaf to tsmp-pdaf-patched-pdaf-CI
676b73c
@jjokella
update model/parflow_pdaf to tsmp-pdaf-patched-pdaf-CI
d757fbb
@jjokella
update model/parflow_pdaf
f45128a
@kvrigor
Copy link
Copy Markdown
Member

kvrigor commented Jul 16, 2025

The issue seems to be the way ParFlow linker flags are manually specified:

TSMP2/cmake/BuildPDAFMODEL.cmake

Lines 98 to 104 in f45128a

if(DEFINED PARFLOW_SRC)
list(APPEND PDAF_LIBS "-L${CMAKE_INSTALL_PREFIX}/lib -lpfsimulator -lamps -lpfkinsol -lgfortran -lcjson")
# GPU
# list(APPEND PDAF_LIBS "-L${CMAKE_INSTALL_PREFIX}/rmm/lib -lstdc++ -lcudart -lrmm -lnvToolsExt")
list(APPEND PDAF_LIBS "-L${HYPRE_ROOT}/lib -lHYPRE")
list(APPEND PDAF_LIBS "-L/lib64 -lslurm")
endif()

The correct linker flags for ParFlow 3rd party dependencies (e.g. CUDA, Hypre) are generated by the ParFlow CMake scripts. Unfortunately TSMP2 cannot directly access these flags since they are dynamically generated. We need to find a way to extract these linker info from ParFlow.

This was referenced Jul 17, 2025
Merged
Closed
@kvrigor kvrigor linked an issue Jul 23, 2025 that may be closed by this pull request
eCLM-ParFlow-PDAF: HYPRE/SLURM library linking issue #84
Closed
@jjokella jjokella mentioned this pull request Apr 15, 2026
Closed
@kvrigor kvrigor removed the PDAF label May 22, 2026
jjokella and others added 8 commits May 28, 2026 16:18
@jjokella
Merge branch 'master' into dev-pdaf-CI
75cd200
@jjokella
CI.yml: indentation fix
af1ad6d
@jjokella
CI: correct CLM3.5 model option
48fb848 
Error from CI

```
 ./build_tsmp2.sh CLM35 ParFlow PDAF --OASIS_SRC /home/runner/work/TSMP2/TSMP2/oasis3-mct --no_update

Unknown parameter passed: CLM35
```
@jjokella
update "models/pdaf"
b34780f
@jjokella @claude
revise HYPRE and SLURM loading
69911b6 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jjokella
update "models/pdaf"
b225a1e
@jjokella
update "models/pdaf"
635e8aa
@jjokella
update "models/pdaf"
1b548a4
@jjokella
Copy link
Copy Markdown
Contributor Author

jjokella commented May 28, 2026 •
edited
Loading

@kvrigor With an update in loading SLURM/HYPRE, the eCLM/CLM3.5-ParFlow-PDAF builds now complete!

Side-Note: Temporary CI failure

I get a strange ICON standalone failure, but this should not be part of this CI.

Note: ICON standalone was failing due to temprorary connection failure to https://gitlab.dkrz.de/icon/icon-model re-running these checks, they complete (as they should with no changes wrt ICON).

@jjokella jjokella requested a review from kvrigor May 29, 2026 14:22
@jjokella
Copy link
Copy Markdown
Contributor Author

jjokella commented May 29, 2026

This turns the PR into

  1. An update of the main PDAF
  2. updates in the compilation scripts
    The from my side could be merged!

I am looking forward to the additional PDAF-related CI-tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvrigor kvrigor Awaiting requested review from kvrigor

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eCLM-ParFlow-PDAF: HYPRE/SLURM library linking issue

2 participants

@jjokella @kvrigor